Fix/library not supporting curl version 8.0.x or higher, Closes #10#85
Fix/library not supporting curl version 8.0.x or higher, Closes #10#85Laeri wants to merge 5 commits intoandelf:masterfrom
Conversation
Modify `misc/compatgen.py` to emit compatability also with version `8.0.0` or higher.
|
Some of the errors disappeared, but I still have the following ones with my changes. |
|
Ok I found out that these options that result in an error when compiling were removed going from version Do you think that simply requiring a minor version of 16 or higher is enough to finish this pull request? |
…from 7.15 to 7.16
Copied from Laeri's andelf#85
|
I got help on #go-nuts in Libera Chat to make this patch work. I was building a program that uses go-curl as a dependency (cameradar) and it used constants that this patch removes. I worked around the problem by adding them back into But the fundamental issue diagnosis I got on #go-nuts was:
So codegen.py would have to be updated to support the new format. |
|
@ilmari-lauhakangas Thanks for having a look at it. I am currently working on other things so I won't be able to do your suggested changes for your info. Hopefully you or someone else can implement the missing changes. |
|
Hi, If it can help in the meantime, I've fixed my go-curl usage with this trivial change: master...batmac:go-curl:batmac |
|
Hello @andelf. Thank you for go-curl. Would you be able to review some pending PRs which fix blockers? Thank you. |
|
@sprive Apologies, it's been quite some time since I've worked with Go. Since Go uses a repo-URL based package management system, I haven't given much attention to maintaining this particular repository. I noticed this PR is still a working-in-progress. Could you provide some hints on which PR I should merge? This project starts at the year 2011. It was the first Go code that implemented a bidirectional callback at that time. |
|
Hello @andelf Definitely do not apologize (this looks great and I see you are exceptionally busy on other projects/languages). I am grateful you put this together as I have some use cases that are best handled by libcurl. :-) So... I had the same error as @Laeri - building go-curl on a system with libcurl 8 or higher. I solved my problem more simply by adding ^^ fixed my build failure. :party: What I could do (please advise): I would create a standalone PR for whichever you choose. Unfortunately I'm not into libcurl (or C) enough to validate what all the different defines are for. But since these rules were written pre-curl 8, it seems to me to be OK in assuming they all mean LIBCURL_VERSION_MAJOR == 7. |
|
@sprive Feel free to add a PR.😁 |
|
Related: #88 PR#88 has some of the cleanup contained in here (but does not try to address the main curl8 issue, yet) |
|
Related: #89 PR#89 contains the remainder of things not in the first PR above. |
Closes #84